Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Add release.yml workflow. #282

Open
wants to merge 1 commit into
base: 8.3-stable
Choose a base branch
from
Open

[WIP]Add release.yml workflow. #282

wants to merge 1 commit into from

Conversation

wa5i
Copy link
Contributor

@wa5i wa5i commented Aug 19, 2022

[skip ci]
发布版本时自动编译 linux、mac 和 windows 二进制包，并上传到 Release Assets 下载项列表中，可以直接下载使用，省去麻烦的编译过程.

Checklist
  • 增加或更新了必要的文档（包括readthedocs上）
  • 增加或更新了必要的测试用例
  • 对于重要修改，更新了CHANGES文件
  • 当前修改存在对已有API参数或返回值的改变
  • 当前修改存在对旧版本功能的兼容性改变（如网络协议或密码算法）

@InfoHunter
Copy link
Member

这是咋触发的？

@InfoHunter
Copy link
Member

在Github上创建新的Release的时候会触发？

@wa5i wa5i force-pushed the 8.3-feature branch 2 times, most recently from 774d1eb to 09b9fec Compare August 19, 2022 08:28
InfoHunter
InfoHunter reviewed Aug 19, 2022
View reviewed changes
.github/workflows/release.yml
nmake install DESTDIR=..\tongsuo
working-directory: _build
- name: pack
run: tar zcvf .\tongsuo-${{ matrix.platform.arch }}.tar.gz .\tongsuo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows也用tar？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows也用tar？

可以的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是说你打包的环境，而是大多数用户的windows环境里都自带tar？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来直接zip一下貌似就OK了。zip好像windows里默认可以解压缩

@wa5i
Copy link
Contributor Author

wa5i commented Aug 19, 2022

在Github上创建新的Release的时候会触发？

是的。
image
打包之后结果如下：
image

@InfoHunter
Copy link
Member

有俩问题：

  1. 缺签名值，你看下目前release时候的asc文件
  2. 这种打包方式其实不属于正式release，里面有很多debug的编译选项，实际上是用于测试目的的。这些二进制包本质上不适合在生产环境中用，容易给用户造成误导

@InfoHunter
Copy link
Member

hold as discussed

@InfoHunter InfoHunter added the hold Something blocks the PR label Aug 30, 2022
@xuyang2
Copy link

xuyang2 commented Aug 30, 2022

ubuntu-latest (当前为 ubuntu-20.04) 的 glibc 版本是 2.31
比 redhat-8 / debian-10 / kylin-v10 都要高，
在 ubuntu-latest 上编译出的二进制包，在 redhat-8 / debian-10 / kylin-v10 上应该都不能用吧

@InfoHunter
Copy link
Member

ubuntu-latest (当前为 ubuntu-20.04) 的 glibc 版本是 2.31
比 redhat-8 / debian-10 / kylin-v10 都要高，
在 ubuntu-latest 上编译出的二进制包，在 redhat-8 / debian-10 / kylin-v10 上应该都不能用吧

所以直接出二进制主要是测试目的，无法面面俱到。真正生产环境的二进制发布，是需要对应到具体发行版的包管理体系中去

@wa5i wa5i changed the title Add release.yml workflow. [WIP]Add release.yml workflow. Aug 31, 2022
@wa5i
Copy link
Contributor Author

wa5i commented Aug 31, 2022

有俩问题：

  1. 缺签名值，你看下目前release时候的asc文件
  2. 这种打包方式其实不属于正式release，里面有很多debug的编译选项，实际上是用于测试目的的。这些二进制包本质上不适合在生产环境中用，容易给用户造成误导

经过讨论后，测试目的的二进制包后面在教程中提供吧，release 界面暂时不提供，后续再看看怎么搞各个系统发行版的 rpm，这个 pr 需要改一下，将测试目的的二进制包发布到 oss，然后在教程中让用户可以下载即可。

@wa5i
Copy link
Contributor Author

wa5i commented Aug 31, 2022

ubuntu-latest (当前为 ubuntu-20.04) 的 glibc 版本是 2.31 比 redhat-8 / debian-10 / kylin-v10 都要高， 在 ubuntu-latest 上编译出的二进制包，在 redhat-8 / debian-10 / kylin-v10 上应该都不能用吧

是的，如上一条回复，后面会以教程的方式提供各个平台的二进制测试包。

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfoHunter InfoHunter InfoHunter left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hold Something blocks the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wa5i @InfoHunter @xuyang2 @CLAassistant